Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase defaults for server-names-hash-max-size and servers-names-hash-bucket-size ConfigMap keys #678

Merged
merged 1 commit into from
Sep 5, 2019
Merged

Increase defaults for server-names-hash-max-size and servers-names-hash-bucket-size ConfigMap keys #678

merged 1 commit into from
Sep 5, 2019
+27 −26

Conversation

LorcanMcVeigh
Copy link
Contributor

Proposed changes

Increased the defaults for server-names-hash-max-size and server-names-hash-max-bucket-size

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@LorcanMcVeigh LorcanMcVeigh self-assigned this Sep 4, 2019
@Dean-Coakley Dean-Coakley added the enhancement Pull requests for new features/feature enhancements label Sep 4, 2019
Dean-Coakley
Dean-Coakley approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Please update the PR title to something more appropriate/descriptive.

E.g:
Increase defaults...
Increase default values for...
etc

@LorcanMcVeigh LorcanMcVeigh changed the title Update server-names-hash-max and servers-names-hash-bucket size Increase defaults for server-names-hash-max and servers-names-hash-bucket size Sep 5, 2019
Rulox
Rulox approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@Rulox Rulox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :shipit:

@LorcanMcVeigh LorcanMcVeigh merged commit b574a51 into master Sep 5, 2019
@LorcanMcVeigh LorcanMcVeigh deleted the update-hash-size branch September 5, 2019 13:54
@Dean-Coakley Dean-Coakley mentioned this pull request Sep 24, 2019
Closed
@pleshakov pleshakov changed the title Increase defaults for server-names-hash-max and servers-names-hash-bucket size Increase defaults for server-names-hash-max-size and servers-names-hash-max-bucket-size ConfigMap keys Dec 17, 2019
@pleshakov pleshakov changed the title Increase defaults for server-names-hash-max-size and servers-names-hash-max-bucket-size ConfigMap keys Increase defaults for server-names-hash-max-size and servers-names-hash-bucket-size ConfigMap keys Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@Rulox Rulox Rulox approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

Assignees

@LorcanMcVeigh LorcanMcVeigh

Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LorcanMcVeigh @pleshakov @Rulox @Dean-Coakley