Add supporting documentation for the project #10
Conversation
peterkellydev
requested review from
isaachawley,
pleshakov,
isserrano and
Dean-Coakley
peterkellydev
added
the
enhancement
There was a problem hiding this comment.
make produces nginx-asg-sync-0.1-2.amzn1.x86_64.rpm nginx-asg-sync-0.1-2.el7.x86_64.rpm nginx-asg-sync_0.2-1-trusty_amd64.deb nginx-asg-sync_0.2-1-xenial_amd64.deb
Please set the version of RPM packages in this line https://github.com/nginxinc/nginx-asg-sync/blob/master/build/package/rpm/SPECS/nginx-asg-sync.spec#L6
peterkellydev
force-pushed
the
release-prep
branch
from
0c9b37a
to
004823f
Compare
Also updates the example yaml apps for rpm and debian to use the new endpoint Contributing guidelines including a code of conduct, issue and pull request templates, and a changelog.
peterkellydev
force-pushed
the
release-prep
branch
from
004823f
to
6ca4bbe
Compare
| ### Git Style Guide | ||
|
|
||
| * Keep a clean, concise and meaningful git commit history on your branch, rebasing locally and squashing before submitting a PR | ||
| * Follow the guidelines of writing a good commit message as described here https://chris.beams.io/posts/git-commit/ and summarised in the next few points |
There was a problem hiding this comment.
here https://chris.beams.io/posts/git-commit/ and summarised in the next few points -> [here] (https://chris.beams.io/posts/git-commit/ and summarised in the next few points)
There was a problem hiding this comment.
thanks @Dean-Coakley but I want the link to appear as it is
|
|
||
| * Run `gofmt` over your code to automatically resolve a lot of style issues. Most editors support this running automatically when saving a code file. | ||
| * Run `go lint` and `go vet` on your code too to catch any other issues. | ||
| * Follow this guide on some good practice and idioms for Go - https://github.com/golang/go/wiki/CodeReviewComments |
There was a problem hiding this comment.
[this guide](https://github.com/golang/go/wiki/CodeReviewComments)
|
Made some small suggestions. I'm happy to get this merged with, or without them |
peterkellydev
force-pushed
the
release-prep
branch
from
2c00a13
to
0bac443
Compare
| @@ -3,7 +3,7 @@ | |||
|
|
|||
| Summary: NGINX Plus integration with AWS Auto Scaling groups | |||
| Name: nginx-asg-sync | |||
| Version: 0.1 | |||
| Version: 0.2 | |||
| Release: 2%{?dist} | |||
There was a problem hiding this comment.
Please change Release: 2%{?dist} to Release: 1%{?dist}
as the current value produces nginx-asg-sync-0.2-2.el7.x86_64.rpm instead of nginx-asg-sync-0.2-1.el7.x86_64.rpm same for the package for Amazon linux
Contributing guidelines including a code of conduct, issue and pull request templates, and a changelog.
Also updates the example yaml apps for rpm and debian to use the new endpoint
Updates version for the next release