Add InService option for AWS #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rulox
approved these changes
May 20, 2020
There was a problem hiding this comment.
lgtm. I asked a question, feel free to ignore if it doesn't make sense.
Additionally, can we add validation to the new field as well with b, err := strconv.ParseBool("true") ? We validate all the fields of the config file here: https://github.com/nginxinc/nginx-asg-sync/blob/master/cmd/sync/aws.go#L184
|
I wasn't sure about adding validation, because a wrong value will throw an error on unmarshal and never reach validation, but I can add that. |
|
Yeah unmarshall validation is enough then @lucacome good point :) |
lucacome
force-pushed
the
filter-in-service
branch
from
7a31607
to
b0b0616
Compare
|
Linking #37 |
lucacome
force-pushed
the
filter-in-service
branch
from
3505e82
to
c8284e3
Compare
pleshakov
approved these changes
May 27, 2020
|
|
||
| batches := prepareBatches(maxItems, instanceIds) | ||
|
|
||
| if len(batches) > len(ids)/maxItems+1 { |
There was a problem hiding this comment.
because we have a specific input here, perhaps it makes sense to use a number, like len(batches) != 2, so that is is easier to read the test?
lucacome
force-pushed
the
filter-in-service
branch
from
48081b6
to
234ab6a
Compare
lucacome
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
in_servicefilter for AWS.If set to
trueonly the instances that are in theInServicestate of the Lifecycle will be added to the upstreams.