Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update log format #42

Merged
merged 4 commits into from
Sep 29, 2020
Merged

Update log format #42

merged 4 commits into from
Sep 29, 2020

Conversation

LorcanMcVeigh
Copy link
Contributor

Proposed changes

update log format from
2020/04/10 21:13:43 Updated HTTP servers of {backend2 80 asg-sync-4-WebserverGroup2-B07B6PPXO49Y http 0xc0000a50e0 0xc0000a50e8 10s 0s}; Added: [{ID:0 Server:172.31.26.57:80 MaxConns:0xc0000a50e0 MaxFails:0xc0000a50e8 FailTimeout:10s SlowStart:0s Route: Backup:<nil> Down:<nil> Drain:false Weight:<nil> Service:}], Removed: [], Updated: []
To new format
2020/04/10 21:13:43 Updated HTTP servers of backend2 for group asg-sync-4-WebserverGroup2-B07B6PPXO49Y: Added: [172.31.26.57:80,172.31.26.61:80], Removed: [], Updated: []

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including a sample output in the PR description. - That's helpful!

cmd/sync/main.go Outdated Show resolved Hide resolved
cmd/sync/main.go Outdated Show resolved Hide resolved
cmd/sync/main.go Outdated Show resolved Hide resolved
cmd/sync/main.go Outdated Show resolved Hide resolved
Co-authored-by: Dean Coakley <dean.s.coakley@gmail.com>
Co-authored-by: Dean Coakley <dean.s.coakley@gmail.com>
cmd/sync/main.go Outdated Show resolved Hide resolved
cmd/sync/main.go Outdated Show resolved Hide resolved
@LorcanMcVeigh LorcanMcVeigh merged commit ba8245f into master Sep 29, 2020
@LorcanMcVeigh LorcanMcVeigh deleted the update-log-format branch September 29, 2020 15:43
@lucacome lucacome added the enhancement Pull requests for new features/feature enhancements label Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants