Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to a single Dockerfile #43

Merged
merged 2 commits into from
Feb 9, 2021
Merged

Move to a single Dockerfile #43

merged 2 commits into from
Feb 9, 2021

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Feb 5, 2021

  • Moving to a single Dockerfile to improve maintainability
  • Added new versions of ubuntu

@lucacome lucacome requested a review from a team February 5, 2021 00:58
@lucacome lucacome self-assigned this Feb 5, 2021
@lucacome lucacome requested review from mikestephen and LorcanMcVeigh and removed request for a team February 5, 2021 00:58
@lucacome
Copy link
Member Author

lucacome commented Feb 5, 2021

Travis will fail because it doesn't support buildkit, we'll need #44

Dean-Coakley
Dean-Coakley approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Not sure about what Ubuntu releases we want to support but supporting extra for now seems fine.

@lucacome
Copy link
Member Author

lucacome commented Feb 9, 2021

Merging with Travis failing because we're going to move to GitHub workflows

@lucacome lucacome merged commit f0d2ab9 into master Feb 9, 2021
@lucacome lucacome deleted the update-makefile branch February 9, 2021 16:40
@lucacome lucacome added the chore Pull requests for routine tasks label Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@LorcanMcVeigh LorcanMcVeigh LorcanMcVeigh approved these changes

@mikestephen mikestephen Awaiting requested review from mikestephen

Assignees

@lucacome lucacome

Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucacome @Dean-Coakley @LorcanMcVeigh