Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced API calls significantly #6

Closed
wants to merge 3 commits into from
Closed

Reduced API calls significantly #6

wants to merge 3 commits into from

Conversation

boostchicken
Copy link

Using the ASG tag on EC2 instances instead of enumerating them by the ASG API

@pleshakov
Copy link
Contributor

@boostchicken thanks for the PR. we'll test your changes in the next few days.

@pleshakov
Copy link
Contributor

@boostchicken
Your changes look good! Thanks again

Before we merge, could you fix a few things:

  • run the modified source files through go fmt tool to fix formatting
  • fix the spelling of the resverations variable
  • change the version back to 0.1-2. We'll prepare a new release with 0.2-1 later this spring and release the new packages as well. your changes will go into that release.
  • squash all the commits into a single one
  • I think this method getInstancesOfReservations becomes redundant. Could you possibly remove it and move the code into GetPrivateIPsOfInstancesOfAutoscalingGroup

@peterkellydev peterkellydev added the enhancement Pull requests for new features/feature enhancements label Jul 27, 2018
@Rulox
Copy link
Contributor

Rulox commented Sep 25, 2019

This was addressed in #29

Closing, thanks.

@Rulox Rulox closed this Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants