Refactor codebase using generic GetPointer function #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjee19
force-pushed
the
debt/generic-getpointer
branch
from
ac75d5a
to
a736f4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: We were still using typed GetPointer functions even after we had created a generic GetPointer function.
Solution: Replaced all uses of typed GetPointer functions with the generic GetPointer function and removed typed GetPointer functions from the codebase.
Testing: Since these changes only affected test files, I ensured that all the tests still pass.
Closes #822
Checklist
Before creating a PR, run through this checklist and mark each as complete.