Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Gateway API SDK to 0.8.0 #1008

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Update Gateway API SDK to 0.8.0 #1008

merged 4 commits into from
Aug 30, 2023

Conversation

sjberman
Copy link
Contributor

@sjberman sjberman commented Aug 29, 2023 •
edited

Updates module, code, and docs to latest Gateway API release. Also removed the webhook-specific error message since the webhook is no longer necessary with the introduction of CEL. Validation error is still printed.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@sjberman sjberman requested a review from a team as a code owner August 29, 2023 16:05
@github-actions github-actions bot added chore Pull requests for routine tasks dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation labels Aug 29, 2023
@sjberman sjberman mentioned this pull request Aug 29, 2023
Closed
6 tasks
kate-osborn
kate-osborn requested changes Aug 29, 2023
View reviewed changes
cmd/gateway/validation.go Outdated Show resolved Hide resolved
internal/mode/static/state/change_processor.go Show resolved Hide resolved
@sjberman
Update Gateway API SDK to 0.8.0
4d5c2ac 
Updates module, code, and docs to latest Gateway API release. Also removed the webhook-specific error message since the webhook is no longer necessary with the introduction of CEL. Validation error is still printed.
@sjberman sjberman enabled auto-merge (squash) August 30, 2023 14:33
@sjberman sjberman merged commit 44cefeb into nginxinc:main Aug 30, 2023
20 checks passed
@sjberman sjberman deleted the chore/upgrade-gw-api branch August 30, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

@kate-osborn kate-osborn kate-osborn approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sjberman @pleshakov @ciarams87 @kate-osborn