Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run conformance tests on minimum k8s version #1020

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

ciarams87
Copy link
Member

@ciarams87 ciarams87 commented Aug 31, 2023

Proposed changes

As a developer
I would like the conformance tests to run on both the latest and minimum supported kubernetes versions
So that I can have confidence that my changes work on all k8s versions we currently support

Solution:
Create a matrix for conformance tests to run both the latest and minimum supported kubernetes versions.

Note: The minimum required version of k8s is 1.23 not 1.22. The Gateway APIs cannot be installed into 1.22:

kubectl apply -f https://github.com/kubernetes-sigs/gateway-api/releases/download/v0.8.0/standard-install.yaml

error: error validating "https://github.com/kubernetes-sigs/gateway-api/releases/download/v0.8.0/standard-install.yaml": error validating data: [ValidationError(CustomResourceDefinition.spec.versions[0].schema.openAPIV3Schema.properties.spec.properties.controllerName): unknown field "x-kubernetes-validations" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.JSONSchemaProps, ValidationError(CustomResourceDefinition.spec.versions[1].schema.openAPIV3Schema.properties.spec.properties.controllerName): unknown field "x-kubernetes-validations" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.JSONSchemaProps]; if you choose to ignore these errors, turn validation off with --validate=false

See https://github.com/kubernetes-sigs/gateway-api/releases

Closes #937

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added chore Pull requests for routine tasks documentation Improvements or additions to documentation labels Aug 31, 2023
@ciarams87 ciarams87 force-pushed the chore/minimum-k8s-version branch 6 times, most recently from b6558b5 to 5255975 Compare August 31, 2023 15:50
@ciarams87 ciarams87 marked this pull request as ready for review August 31, 2023 15:50
@ciarams87 ciarams87 requested a review from a team as a code owner August 31, 2023 15:50
.github/workflows/conformance.yml Show resolved Hide resolved
.github/workflows/conformance.yml Outdated Show resolved Hide resolved
@ciarams87 ciarams87 merged commit b55d1bc into nginxinc:main Sep 1, 2023
23 checks passed
@ciarams87 ciarams87 deleted the chore/minimum-k8s-version branch September 1, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Automated test for minimum Kubernetes version
3 participants