Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dots in helm release name #1022

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

ciarams87
Copy link
Member

Problem: Helm tests are failing when there is a dot in the branch or tag name, as this is used for the helm release name which is not allowed

Solution: Replace any dots in the release name with dashes

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ciarams87 ciarams87 requested a review from a team as a code owner August 31, 2023 15:19
@github-actions github-actions bot added the chore Pull requests for routine tasks label Aug 31, 2023
@ciarams87 ciarams87 merged commit e7c8a21 into nginxinc:main Aug 31, 2023
22 checks passed
@ciarams87 ciarams87 deleted the chore/fix-helm.tests branch August 31, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants