Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for release to exist for conformance tests #1024

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

sjberman
Copy link
Contributor

Problem: The release needs to exist before we run the conformance tests on a release tag.

Solution: Move the "wait" job to earlier in the process.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@sjberman sjberman requested a review from a team as a code owner August 31, 2023 16:36
@github-actions github-actions bot added the bug Something isn't working label Aug 31, 2023
Problem: The release needs to exist before we run the conformance tests on a release tag.

Solution: Move the "wait" job to earlier in the process.
@sjberman sjberman enabled auto-merge (squash) August 31, 2023 19:55
@sjberman sjberman merged commit 4379a6e into nginxinc:main Aug 31, 2023
22 checks passed
@sjberman sjberman deleted the fix/conformance-profile branch August 31, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants