Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor codebase to use inline error checking #1026

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Refactor codebase to use inline error checking #1026

merged 2 commits into from
Sep 1, 2023

Conversation

bjee19
Copy link
Contributor

@bjee19 bjee19 commented Aug 31, 2023

Proposed changes

Use inline error checking in go code.

Problem: There were some places in the codebase where inline error checking wasn't used.

Solution: Refactor codebase to use inline error checking.

Testing: Ensured unit tests pass.

Closes #821

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@bjee19 bjee19 requested a review from a team as a code owner August 31, 2023 23:23
@github-actions github-actions bot added the tech-debt Short-term pain, long-term benefit label Aug 31, 2023
ciarams87
ciarams87 approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bjee19 bjee19 merged commit fb81d59 into nginxinc:main Sep 1, 2023
23 checks passed
@bjee19 bjee19 deleted the debt/inline-error-checking branch September 1, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjberman sjberman sjberman approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

Assignees
No one assigned
Labels
tech-debt Short-term pain, long-term benefit
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use inline error checking in go code
3 participants
@bjee19 @sjberman @ciarams87