Add readiness probe #1047
Merged
Add readiness probe #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
sjberman
commented
Sep 8, 2023
sjberman
commented
Sep 8, 2023
bjee19
reviewed
Sep 8, 2023
kate-osborn
approved these changes
Sep 8, 2023
bjee19
approved these changes
Sep 8, 2023
ciarams87
requested changes
Sep 11, 2023
ciarams87
approved these changes
Sep 11, 2023
pleshakov
reviewed
Sep 11, 2023
sjberman
force-pushed
the
feat/health-probes
branch
from
f76a5d8
to
940e548
Compare
Problem: The NKG Pod would report Ready as soon as it started, which could lead to traffic being sent too soon before nginx was actually configured. Solution: Add a readiness probe that will report Ready once the controller has written its first config to nginx (or has nothing to do on startup). Also changed the metrics "disable" helm flag to "enable" to be consistent and easier to read.
sjberman
force-pushed
the
feat/health-probes
branch
from
7a03408
to
acd4b84
Compare
pleshakov
reviewed
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The NKG Pod would report Ready as soon as it started, which could lead to traffic being sent too soon before nginx was actually configured.
Solution: Add a readiness probe that will report Ready once the controller has written its first config to nginx (or has nothing to do on startup).
Also changed the metrics "disable" helm flag to "enable" to be consistent and easier to read. (This is a pre-1.0 breaking change).
Testing: Manually verified that an upgrade has no downtime for connections.
Closes #542