Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for configurable securityContext #1063

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

sjberman
Copy link
Contributor

Problem: In at least one environment it has been found that the control plane does not have permissions to reload nginx, requiring allowPrivilegeEscalation to be true.

Solution: Keep the same default, but allow this field to be configurable. Added a troubleshooting guide for this issue.

Closes #1055

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Problem: In at least one environment it has been found that the control plane does not have permissions to reload nginx, requiring allowPrivilegeEscalation to be true.

Solution: Keep the same default, but allow this field to be configurable. Added a troubleshooting guide for this issue.
@sjberman sjberman requested a review from a team as a code owner September 18, 2023 14:38
@github-actions github-actions bot added bug Something isn't working documentation Improvements or additions to documentation labels Sep 18, 2023
@sjberman sjberman merged commit 2ca026e into nginxinc:main Sep 18, 2023
23 checks passed
@sjberman sjberman deleted the bug/configurable-permissions branch September 18, 2023 17:24
@poneding
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

failed to reload NGINX: failed to send the HUP signal to NGINX main: operation not permitted
5 participants