Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename NGINX Kubernetes Gateway #1070

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

sjberman
Copy link
Contributor

Renaming NGINX Kubernetes Gateway to NGINX Gateway Fabric. NKG is renamed to NGF

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation labels Sep 18, 2023
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
conformance/Makefile Show resolved Hide resolved
conformance/provisioner/provisioner.yaml Show resolved Hide resolved
deploy/helm-chart/README.md Outdated Show resolved Hide resolved
docs/cli-help.md Outdated Show resolved Hide resolved
docs/installation.md Show resolved Hide resolved
examples/cafe-example/README.md Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@bjee19
Copy link
Contributor

bjee19 commented Sep 18, 2023

docs/images/cert-manager-gateway-workflow.png Outdated Show resolved Hide resolved
docs/monitoring.md Outdated Show resolved Hide resolved
@sjberman sjberman marked this pull request as ready for review September 19, 2023 16:49
@sjberman sjberman requested a review from a team as a code owner September 19, 2023 16:49
Makefile Outdated Show resolved Hide resolved
@bjee19
Copy link
Contributor

bjee19 commented Sep 19, 2023

@kate-osborn
Copy link
Contributor

https://github.com/nginxinc/nginx-kubernetes-gateway/blob/af899e181ac63280685177e548b3379c60d4b861/cmd/gateway/commands.go#L244

and the next couple lines

Ty for catching. I forgot I added some references:

cmd/gateway/commands.go:244:            "Disable leader election. Leader election is used to avoid multiple replicas of the NGINX Kubernetes Gateway"+
cmd/gateway/commands.go:246:                    "all replicas of NGINX Kubernetes Gateway will update the statuses of the Gateway API resources.",
deploy/helm-chart/values.yaml:16:  ## The number of replicas of the NGINX Kubernetes Gateway Deployment.
deploy/helm-chart/values.yaml:20:    ## Enable leader election. Leader election is used to avoid multiple replicas of the NGINX Kubernetes Gateway
deploy/helm-chart/values.yaml:21:    ## reporting the status of the Gateway API resources. If not enabled, all replicas of NGINX Kubernetes Gateway

Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looked through each file, hopefully if we missed something we'll catch it later!

CHANGELOG.md Show resolved Hide resolved
README.md Show resolved Hide resolved
docs/cli-help.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Renaming NGINX Kubernetes Gateway to NGINX Gateway Fabric. NKG is renamed to NGF
@ciarams87 ciarams87 merged commit e9ae68a into nginxinc:main Sep 20, 2023
23 checks passed
@sjberman sjberman deleted the chore/rename branch September 20, 2023 13:42
@sjberman sjberman added the change Pull requests that introduce a change label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change Pull requests that introduce a change chore Pull requests for routine tasks dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants