Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add longevity test plan and results #1113

Merged
merged 9 commits into from
Oct 11, 2023
Merged

Add longevity test plan and results #1113

merged 9 commits into from
Oct 11, 2023

Conversation

pleshakov
Copy link
Contributor

Proposed changes

Problem:

  • We don't know if NGF can successfully process both control plane and data plane transactions over a period of time much greater than in our tests.
  • We didn't yet try to catch bugs that could only appear over a period of time (like resource leaks).

Solution:

  • Create a longevity test plan
  • Run the test
  • Document the results

CLOSES #956

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pleshakov pleshakov requested a review from a team as a code owner October 6, 2023 16:07
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 6, 2023
@pleshakov pleshakov force-pushed the test/longevity branch 2 times, most recently from 34e3379 to 635544d Compare October 6, 2023 16:32
@pleshakov
Add longevity test plan and results
404ff96 
Problem:
* We don't know if NGF can successfully process both control plane and
data plane transactions over a period of time much greater than in our
tests.
* We didn't yet try to catch bugs that could only appear over a period
of time (like resource leaks).

Solution:
- Create a longevity test plan
- Run the test
- Document the results

CLOSES nginxinc#956
bjee19
bjee19 requested changes Oct 6, 2023
View reviewed changes
tests/longevity/longevity.md Outdated Show resolved Hide resolved
tests/longevity/longevity.md Outdated Show resolved Hide resolved
tests/longevity/longevity.md Outdated Show resolved Hide resolved
tests/longevity/longevity.md Outdated Show resolved Hide resolved
tests/longevity/longevity.md Outdated Show resolved Hide resolved
kate-osborn
kate-osborn reviewed Oct 6, 2023
View reviewed changes
Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Great job on this.

One suggestion:

Can you add details on how you created the metrics graphs in GKE? It would be great to be able to reproduce the graphs you included in this PR.

@pleshakov
Copy link
Contributor Author

@kate-osborn

Can you add details on how you created the metrics graphs in GKE? It would be great to be able to reproduce the graphs you included in this PR.

I did save the dashboard in our private infra under the name "NGF Longevity Test", but it is also possible to export it as JSON. I can also mention the name in the docs. Let me know

@pleshakov @bjee19
Apply suggestions from code review
bb50c6e 
Co-authored-by: bjee19 <139261241+bjee19@users.noreply.github.com>
sjberman
sjberman reviewed Oct 9, 2023
View reviewed changes
tests/longevity/longevity.md Show resolved Hide resolved
tests/longevity/longevity.md Outdated Show resolved Hide resolved
tests/longevity/longevity.md Outdated Show resolved Hide resolved
bjee19
bjee19 requested changes Oct 9, 2023
View reviewed changes
tests/longevity/longevity.md Outdated Show resolved Hide resolved
tests/longevity/results/1.0.0.md Outdated Show resolved Hide resolved
@kate-osborn
Copy link
Contributor

@kate-osborn

Can you add details on how you created the metrics graphs in GKE? It would be great to be able to reproduce the graphs you included in this PR.

I did save the dashboard in our private infra under the name "NGF Longevity Test", but it is also possible to export it as JSON. I can also mention the name in the docs. Let me know

That should be fine. We can always add the JSON dashboard in the future if it becomes an issue. Let's not mention the name in our docs since it's a private account.

kate-osborn
kate-osborn requested changes Oct 9, 2023
View reviewed changes
tests/longevity/longevity.md Outdated Show resolved Hide resolved
tests/longevity/results/1.0.0.md Outdated Show resolved Hide resolved
@pleshakov pleshakov mentioned this pull request Oct 10, 2023
Open
kate-osborn
kate-osborn approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

bjee19
bjee19 approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pleshakov pleshakov merged commit 71d605e into nginxinc:main Oct 11, 2023
23 checks passed
@pleshakov pleshakov deleted the test/longevity branch October 11, 2023 16:06
@ciarams87 ciarams87 added the tests Pull requests that update tests label Oct 17, 2023
@pleshakov pleshakov mentioned this pull request Oct 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

@kate-osborn kate-osborn kate-osborn approved these changes

@bjee19 bjee19 bjee19 approved these changes

@sjberman sjberman Awaiting requested review from sjberman

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation tests Pull requests that update tests
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Baseline Testing: Longevity
5 participants
@pleshakov @kate-osborn @sjberman @ciarams87 @bjee19