-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add longevity test plan and results #1113
Conversation
34e3379
to
635544d
Compare
Problem: * We don't know if NGF can successfully process both control plane and data plane transactions over a period of time much greater than in our tests. * We didn't yet try to catch bugs that could only appear over a period of time (like resource leaks). Solution: - Create a longevity test plan - Run the test - Document the results CLOSES nginxinc#956
635544d
to
404ff96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! Great job on this.
One suggestion:
Can you add details on how you created the metrics graphs in GKE? It would be great to be able to reproduce the graphs you included in this PR.
I did save the dashboard in our private infra under the name "NGF Longevity Test", but it is also possible to export it as JSON. I can also mention the name in the docs. Let me know |
Co-authored-by: bjee19 <139261241+bjee19@users.noreply.github.com>
That should be fine. We can always add the JSON dashboard in the future if it becomes an issue. Let's not mention the name in our docs since it's a private account. |
Co-authored-by: bjee19 <139261241+bjee19@users.noreply.github.com>
Co-authored-by: Saylor Berman <s.berman@f5.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Proposed changes
Problem:
Solution:
CLOSES #956
Checklist
Before creating a PR, run through this checklist and mark each as complete.