Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scale test #1115

Merged
merged 18 commits into from
Oct 10, 2023
Merged

Scale test #1115

merged 18 commits into from
Oct 10, 2023

Conversation

kate-osborn
Copy link
Contributor

Proposed changes

Problem: We need to understand how NGF performs when resources are scaled.

Solution: Adds results from manual scale tests and steps on how to run the scale tests.

Testing: Ran the scale tests described in this changest.

Closes #954

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@kate-osborn kate-osborn requested a review from a team as a code owner October 6, 2023 17:53
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 6, 2023
bjee19
bjee19 requested changes Oct 6, 2023
View reviewed changes
tests/scale/README.md Outdated Show resolved Hide resolved
tests/scale/README.md Outdated Show resolved Hide resolved
tests/scale/README.md Outdated Show resolved Hide resolved
tests/scale/README.md Outdated Show resolved Hide resolved
bjee19
bjee19 requested changes Oct 6, 2023
View reviewed changes
tests/scale/README.md Outdated Show resolved Hide resolved
pleshakov
pleshakov reviewed Oct 6, 2023
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments and suggestions. The major ones that will require re-running of tests, we can implement in the next iterations.

tests/scale/scale_test.go Outdated Show resolved Hide resolved
tests/scale/scale_test.go Show resolved Hide resolved
tests/scale/scale_test.go Outdated Show resolved Hide resolved
tests/scale/generate_manifests.go Show resolved Hide resolved
tests/scale/results/summary.md Outdated Show resolved Hide resolved
tests/scale/results/summary.md Outdated Show resolved Hide resolved
tests/scale/README.md Outdated Show resolved Hide resolved
tests/scale/README.md Outdated Show resolved Hide resolved
tests/scale/README.md Outdated Show resolved Hide resolved
bjee19
bjee19 requested changes Oct 9, 2023
View reviewed changes
tests/scale/results/1.0.0/1.0.0.md Outdated Show resolved Hide resolved
tests/scale/scale_test.go Outdated Show resolved Hide resolved
tests/scale/scale_test.go Outdated Show resolved Hide resolved
pleshakov
pleshakov approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

kate-osborn and others added 16 commits October 10, 2023 13:44
kate-osborn and others added 2 commits October 10, 2023 13:44
@kate-osborn @bjee19
Update tests/scale/results/1.0.0/1.0.0.md
a55da33 
Co-authored-by: bjee19 <139261241+bjee19@users.noreply.github.com>
@kate-osborn
Use inline error checking
62936d3
bjee19
bjee19 approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@kate-osborn kate-osborn added the tests Pull requests that update tests label Oct 10, 2023
@kate-osborn kate-osborn merged commit b3fbf98 into nginxinc:main Oct 10, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@sjberman sjberman sjberman approved these changes

@bjee19 bjee19 bjee19 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation tests Pull requests that update tests
Projects
NGINX Gateway Fabric
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Baseline Testing: Scale testing
4 participants
@kate-osborn @pleshakov @sjberman @bjee19