Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataplane performance test #1140

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Conversation

ciarams87
Copy link
Member

Proposed changes

Problem: As a developer of NGF, I want to know the average latency of requests being proxied through NGINX using a variety of routing rules, so that I can know if different routing rules provide different results, and so that I can know if any future work has an impact on data plane performance.

Solution: Create HTTPRoutes to configure different matches all pointing to the same application, use wrk to send requests to the different routes, and capture the results.

Please focus on (optional): I only have a single backend application to ensure that wasn't an influential factor in the performance measurement.

Closes #953

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ciarams87 ciarams87 requested a review from a team as a code owner October 13, 2023 14:47
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 13, 2023
tests/dataplane-performance/results/1.0.0.md Outdated Show resolved Hide resolved
tests/dataplane-performance/setup.md Outdated Show resolved Hide resolved
tests/dataplane-performance/results/1.0.0.md Outdated Show resolved Hide resolved
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ciarams87 ciarams87 added the tests Pull requests that update tests label Oct 17, 2023
@ciarams87 ciarams87 merged commit 6707e5a into nginxinc:main Oct 17, 2023
23 checks passed
@ciarams87 ciarams87 deleted the tests/dp-performance branch October 17, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Baseline Testing: Data plane performance
5 participants