Improve installation doc #1153
Merged
Improve installation doc #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
6 tasks
sjberman
approved these changes
Oct 17, 2023
pleshakov
approved these changes
Oct 17, 2023
kate-osborn
force-pushed
the
docs/add-note-about-gateway
branch
from
2b5515a
to
27de5dc
Compare
bjee19
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: The installation doc does not mention that NGINX will not listen until a Gateway is created.
This can be confusing for first-time users. See #977.
Solution: Add note to installation doc.
Closes #1152
Checklist
Before creating a PR, run through this checklist and mark each as complete.