Fix conformance release workflow #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The job used in the conformance tests to wait for the release to exist wasn't working properly. It only saw jobs in progress, and not jobs that are pending, which is what we needed to wait for. Solution: Removed the action and replaced with a basic polling loop to ensure the NGF images exist before continuing with the tests.
sjberman
force-pushed
the
chore/fix-conformance-release
branch
from
e714511
to
974702f
Compare
bjee19
approved these changes
Oct 25, 2023
kate-osborn
approved these changes
Oct 25, 2023
ciarams87
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The job used in the conformance tests to wait for the release to exist wasn't working properly. It only saw jobs in progress, and not jobs that are pending, which is what we needed to wait for.
Solution: Removed the action and replaced with a basic polling loop to ensure the NGF images exist before continuing with the tests.
Testing: Verified that the job properly waits in a forked release pipeline.
Closes #1197