Ensure failed conformance tests are caught in pipeline & fix local make command

[ciarams87]

Proposed changes

Problem: The variables in the make target for running conformance tests are not being properly evaluated in the pipeline. This means we're missing failed conformance tests in the pipeline at the moment because we always return green even if there was a conformance test failure.

Solution: This PR fixes that by checking if there was a failure in the test run and exiting the CI job with the exit code 2 if there is a failure. Also fixes the case where the target make variables are not being set correctly when the make run-conformance-tests are being ran locally.

Testing: Tested locally and in #1169

Checklist

Before creating a PR, run through this checklist and mark each as complete.

• I have read the CONTRIBUTING doc
• I have added tests that prove my fix is effective or that my feature works
• I have checked that all unit tests pass after adding my changes
• I have updated necessary documentation
• I have rebased my branch onto main
• I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

[sjberman]

Approved before I saw the failure..so holding off.

[bjee19]

So to make sure I'm understanding this correctly, we want the conformance test to be failing as that is how we know we are correctly catching this case in the pipeline? What does "Fail conf tests in pipeline" mean in the title?

[ciarams87]

So to make sure I'm understanding this correctly, we want the conformance test to be failing as that is how we know we are correctly catching this case in the pipeline? What does "Fail conf tests in pipeline" mean in the title?

@bjee19 We're missing failed conformance tests in the pipeline at the moment because we always return green even if there was a conformance test failure. This PR fixes that by checking if there was a failure in the test run and exiting the CI job with the exit code 2 if there is a failure. I'll update the description to be more clear 😄