Update documents to cover CEL validation on CRDs #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
kate-osborn
reviewed
Nov 1, 2023
pleshakov
reviewed
Nov 1, 2023
❌ Deploy Preview for nginx-gateway-fabric failed.
|
bjee19
force-pushed
the
docs/cel-validation
branch
from
8331d10
to
72a716f
Compare
pleshakov
approved these changes
Nov 8, 2023
sjberman
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update resource validation docs to cover CEL validation.
Problem: Gateway API 0.8.0 introduced CEL based-validation and the shift away from webhook validation.
Solution: Updated the resource validation docs to cover CEL validation for supported Kubernetes versions and kept webhook validation for older versions.
Please focus on (optional): @sjberman and I discussed if we should leave in areas where we mention rerunning the validation webhook on the NGF side as that would not be needed for newer versions of Kubernetes and Saylor advised me to take it out of the documents but wanted to hear what the rest of the team thought. For Kubernetes versions 1.23 and 1.24 where using the validation webhook is still advised, should we still mention in our docs that we rerun the webhook on our end?
Closes #971
Checklist
Before creating a PR, run through this checklist and mark each as complete.