Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal (Implementable): data plane config #1215

Merged
merged 4 commits into from
Nov 3, 2023
Merged

Proposal (Implementable): data plane config #1215

merged 4 commits into from
Nov 3, 2023

Conversation

sjberman
Copy link
Contributor

@sjberman sjberman commented Nov 1, 2023

Update enhancement proposal with implementable details for NGF data plane dynamic configuration.

Closes #929

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@sjberman sjberman requested a review from a team as a code owner November 1, 2023 17:27
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 1, 2023
pleshakov
pleshakov reviewed Nov 1, 2023
View reviewed changes
docs/proposals/data-plane-config.md Outdated Show resolved Hide resolved
docs/proposals/data-plane-config.md Outdated Show resolved Hide resolved
docs/proposals/data-plane-config.md Outdated Show resolved Hide resolved
docs/proposals/data-plane-config.md Show resolved Hide resolved
docs/proposals/data-plane-config.md Outdated Show resolved Hide resolved
docs/proposals/data-plane-config.md Show resolved Hide resolved
docs/proposals/data-plane-config.md Show resolved Hide resolved
docs/proposals/data-plane-config.md Show resolved Hide resolved
docs/proposals/data-plane-config.md Show resolved Hide resolved
docs/proposals/data-plane-config.md Outdated Show resolved Hide resolved
@sjberman
Proposal (Implementable): data plane config
f97792f 
Update enhancement proposal with implementable details for NGF data plane dynamic configuration.
@sjberman
Code review feedback
570487e
kate-osborn
kate-osborn approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pleshakov
pleshakov approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sjberman sjberman enabled auto-merge (squash) November 3, 2023 19:36
@sjberman sjberman merged commit c0c586b into nginxinc:main Nov 3, 2023
21 checks passed
sjberman added a commit that referenced this pull request Nov 3, 2023
@sjberman
Proposal (Implementable): data plane config (#1215)
fc03f38 
Update enhancement proposal with implementable details for NGF data plane dynamic configuration.
@sjberman sjberman deleted the docs/dp-config-proposal branch November 3, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@kate-osborn kate-osborn kate-osborn approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data Plane Dynamic Configuration
3 participants
@sjberman @pleshakov @kate-osborn