Merge HTTPRoute conditions #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleshakov
approved these changes
Nov 3, 2023
sjberman
approved these changes
Nov 3, 2023
kate-osborn
force-pushed
the
fix/merge-conditions
branch
from
e518733
to
6851dd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: NGF overwrites the HTTPRoute parent statuses written by other Gateway API controllers.
Solution: Merge the existing HTTPRoute parent statuses owned by other controllers with NGF's parent statuses.
Testing: Attached an HTTPRoute to NGF's gateway and another controller's gateway and verified that the HTTPRoute parent statuses are merged.
Closes #558
Checklist
Before creating a PR, run through this checklist and mark each as complete.