Support multiple routes per path #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kate-osborn
force-pushed
the
support-multiple-matches
branch
from
2cc1267
to
0cffe13
Compare
f5yacobucci
approved these changes
Jun 16, 2022
pleshakov
suggested changes
Jun 22, 2022
* Adds new boolean field "any" to internal httpMatch object. An httpMatch with any=true represents a path-only match. Any request sent to the path will satisfy this match. * Changes algorithm for sorting routes to match the rules defined by the spec. * Adds local development instructions for njs module as well as test coverage output. * Updates advanced-routing example to demonstrate new capabilities.
Co-authored-by: Michael Pleshakov <pleshakov@users.noreply.github.com>
kate-osborn
force-pushed
the
support-multiple-matches
branch
from
9cf5cab
to
e9e6a20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Support multiple routes per path.
anyto the internalhttpMatchobject. AnhttpMatchwithany=truerepresents a path-only match. Any request sent to the path will satisfy this match.HTTPRouteswith nil matches. The schema forHTTPRoutesenforces a default match, so matches will never be nil./srccontains source files/testcontains test filesChecklist