Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic system test with utilities #1274

Merged
merged 5 commits into from
Nov 27, 2023

Conversation

sjberman
Copy link
Contributor

Problem: In order to test a full NGF system running in k8s, we need a framework that can easily deploy apps and send traffic.

Solution: Enhance the framework with functions to create apps and send traffic using port forwarding. Also added a basic test to utilize these functions as a proof of concept.

Closes #1218

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@sjberman sjberman requested a review from a team as a code owner November 20, 2023 22:32
@github-actions github-actions bot added documentation Improvements or additions to documentation tests Pull requests that update tests labels Nov 20, 2023
tests/suite/system_suite_test.go Outdated Show resolved Hide resolved
tests/suite/system_suite_test.go Outdated Show resolved Hide resolved
tests/suite/sample_test.go Outdated Show resolved Hide resolved
tests/suite/sample_test.go Show resolved Hide resolved
tests/framework/resourcemanager.go Outdated Show resolved Hide resolved
tests/framework/portforward.go Show resolved Hide resolved
tests/framework/portforward.go Outdated Show resolved Hide resolved
tests/suite/system_suite_test.go Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
@sjberman sjberman force-pushed the tests/app-utility branch 2 times, most recently from 8d1f027 to 5f20ec0 Compare November 21, 2023 21:45
tests/README.md Outdated Show resolved Hide resolved
Problem: In order to test a full NGF system running in k8s, we need a framework that can easily deploy apps and send traffic.

Solution: Enhance the framework with functions to create apps and send traffic using port forwarding. Also added a basic test to utilize these functions as a proof of concept.
tests/README.md Outdated Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
tests/framework/portforward.go Outdated Show resolved Hide resolved
tests/framework/portforward.go Outdated Show resolved Hide resolved
tests/framework/request.go Outdated Show resolved Hide resolved
tests/framework/resourcemanager.go Outdated Show resolved Hide resolved
Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sjberman sjberman merged commit fdbe668 into nginxinc:main Nov 27, 2023
21 of 23 checks passed
@sjberman sjberman deleted the tests/app-utility branch November 27, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Utility to install example application
4 participants