Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken chart icon links #1289 #1290

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Fix broken chart icon links #1289 #1290

merged 2 commits into from
Nov 30, 2023

Conversation

arukiidou
Copy link
Contributor

@arukiidou arukiidou commented Nov 30, 2023 •
edited

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Solution: icon fixes

Testing: ✅display https://raw.githubusercontent.com/nginxinc/nginx-gateway-fabric/main/deploy/helm-chart/chart-icon.png

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@arukiidou arukiidou requested a review from a team as a code owner November 30, 2023 11:57
@github-actions github-actions bot added chore Pull requests for routine tasks helm-chart Relates to helm chart labels Nov 30, 2023
@arukiidou
Fix broken chart icon links nginxinc#1289
9422c71 
Signed-off-by: junya koyama <arukiidou@yahoo.co.jp>
@netlify Netlify
Copy link

netlify bot commented Nov 30, 2023 •
edited

✅ Deploy Preview for nginx-gateway-fabric canceled.

Name Link
🔨 Latest commit b99d7fc
🔍 Latest deploy log https://app.netlify.com/sites/nginx-gateway-fabric/deploys/6568c6b69a415a0008edcbd5

@sjberman sjberman enabled auto-merge (squash) November 30, 2023 17:30
@sjberman sjberman merged commit ebcd31d into nginxinc:main Nov 30, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@sjberman sjberman sjberman approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks helm-chart Relates to helm chart
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chart.yaml - broken helm chart icon links(404: Not Found)
3 participants
@arukiidou @pleshakov @sjberman