Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more detail to helm install commands #1299

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Add more detail to helm install commands #1299

merged 3 commits into from
Dec 4, 2023
+93 −24

Conversation

sjberman
Copy link
Contributor

Problem: Some environments may not want to have a Service installed by default. Our instructions for installing via helm are not clear about this.

Solution: Update helm installation docs to be clear about how to alter the installation commands. Also cleaned up the commands/docs a bit.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@sjberman
Add more detail to helm install commands
aef16f8 
Problem: Some environments may not want to have a Service installed by default. Our instructions for installing via helm are not clear about this.

Solution: Update helm installation docs to be clear about how to alter the installation commands. Also cleaned up the commands/docs a bit.
@sjberman sjberman requested a review from a team as a code owner November 30, 2023 18:44
@netlify Netlify
Copy link

netlify bot commented Nov 30, 2023 •
edited

✅ Deploy Preview for nginx-gateway-fabric ready!

Name Link
🔨 Latest commit 5cb0074
🔍 Latest deploy log https://app.netlify.com/sites/nginx-gateway-fabric/deploys/656dec06abac5c00070e355f
😎 Deploy Preview https://deploy-preview-1299--nginx-gateway-fabric.netlify.app/nginx-gateway-fabric/installation/running-on-kind
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sjberman sjberman requested a review from a team November 30, 2023 18:44
@github-actions github-actions bot added documentation Improvements or additions to documentation helm-chart Relates to helm chart labels Nov 30, 2023
ADubhlaoich
ADubhlaoich approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sjberman sjberman enabled auto-merge (squash) December 4, 2023 14:53
@sjberman sjberman merged commit 78be712 into nginxinc:main Dec 4, 2023
27 checks passed
@sjberman sjberman deleted the docs/helm-commands branch December 4, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

@kate-osborn kate-osborn kate-osborn approved these changes

@bjee19 bjee19 bjee19 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation helm-chart Relates to helm chart
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sjberman @ADubhlaoich @ciarams87 @kate-osborn @bjee19