Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update the readme with correct compatibility doc link #1322

Merged
merged 1 commit into from
Dec 4, 2023
Merged

docs: update the readme with correct compatibility doc link #1322

merged 1 commit into from
Dec 4, 2023

Conversation

sanathkumarbs
Copy link
Contributor

@sanathkumarbs sanathkumarbs commented Dec 2, 2023 •
edited

Proposed changes

Problem: The Compatability Document referenced in README.md points to a broken link.

Solution: This PR updates it to the correct one.

Testing: Manually tested the README.md, which works with the newer link.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@sanathkumarbs sanathkumarbs requested a review from a team as a code owner December 2, 2023 21:46
@netlify Netlify
Copy link

netlify bot commented Dec 2, 2023 •
edited

✅ Deploy Preview for nginx-gateway-fabric canceled.

Name Link
🔨 Latest commit e19a6d5
🔍 Latest deploy log https://app.netlify.com/sites/nginx-gateway-fabric/deploys/656ba5b944477900085db4a1

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 2, 2023
ADubhlaoich
ADubhlaoich approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sjberman sjberman merged commit 394aaa5 into nginxinc:main Dec 4, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@sjberman sjberman sjberman approved these changes

@Jcahilltorre Jcahilltorre Jcahilltorre approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sanathkumarbs @ADubhlaoich @sjberman @Jcahilltorre