[Bug] Set file mode explicitly for regular files

[kevin85421]

Proposed changes

• As shown in the following code snippet, the function ensureFiles checks the file mode for both regular files and secret files.
  

  nginx-gateway-fabric/internal/mode/static/nginx/file/manager_test.go

  Lines 43 to 47 in 6d4cfd7

  	if f.Type == file.TypeRegular {
  	Expect(info.Mode()).To(Equal(os.FileMode(0o644)))
  	} else {
  	Expect(info.Mode()).To(Equal(os.FileMode(0o640)))
  	}

• The function ReplaceFiles in nginx/file/manager.go creates files by internally calling os.Create, which, by default, creates files with mode 0666 (before applying umask). See the source code of os.Create for more details.

• The function writeFile changes the mode of secret files to 0640 by calling chmod, but does nothing for regular files. Hence, the check Expect(info.Mode()).To(Equal(os.FileMode(0o644))) in nginx/file/manager_test.go only passes for umask with specific values.

• In my environment, the umask value is 002. Therefore, the mode for regular files will be 0666 - 0002 = 0664, causing the unit test to fail. In the following screenshot, 420 is 0o644, and 436 is 0o664.
  

• Solution: This PR sets the file mode explicitly.

Checklist

Closes #1328

Before creating a PR, run through this checklist and mark each as complete.

• I have read the CONTRIBUTING doc
• I have added tests that prove my fix is effective or that my feature works
• I have checked that all unit tests pass after adding my changes
• I have updated necessary documentation
• I have rebased my branch onto main
• I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

• Run make unit-test locally.
  

[netlify]

✅ Deploy Preview for nginx-gateway-fabric ready!

Name	Link
🔨 Latest commit	1976f20
🔍 Latest deploy log	https://app.netlify.com/sites/nginx-gateway-fabric/deploys/656f3cabd64150000896d48a
😎 Deploy Preview	https://deploy-preview-1323--nginx-gateway-fabric.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[sjberman]

Please update your main commit message to contain the basic problem/solution as defined in your PR description.

[sjberman]

Could you also create an associated bug to track and close with this PR?

[kevin85421]

Please update your main commit message to contain the basic problem/solution as defined in your PR description.

Would you mind providing more details? Most open-source projects in which I have maintained/contributed squashed commits from a PR into a single commit and written the messages there. I am not sure how does NGINX community works.

In my understanding, you ask me to squash the commits manually and write the commit message:

# Step 1: Reset the 2 commits in this PR
git reset HEAD^^

# Step 2:
git add ${ALL_FILES_GOT_RESET}

# Step 3: Write commit message here
git commit

# Step 4:
git push -f ...

Is my understanding correct?

Could you also create an associated bug to track and close with this PR?

I have already opened an issue #1328.

[sjberman]

Yes, we can supply the commit message when squashing on a merge. However, it makes it easier for us when reviewing to know what changes are going into each commit. "update" doesn't tell us anything useful about the changes that were made in that commit.

It also saves us the step of copying the PR description into the squashed commit message because it'll already be there if you have that commit message to start with.

You don't have to squash the commits manually, but the first commit should at least have a useful message (likely matching your PR description).

[sjberman]

You can also squash or change a commit message by doing git rebase -i head~X where X is the number of commits you want to go back and manage.

[kevin85421]

Thank you for the explanation! It's a bit embarrassing, but this is the first time I've learned how to write long commit messages locally lol. I have already updated the PR.