Handle repeated headers #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an HTTPHeaderMatch contains entries with equivalent header names, we will only configure
the first entry. We will ignore all other entries with that name. Header names are
case-insensitive, so "Foo" is equivalent to "foo".
If an HTTP request has repeated headers, nginx will merge the values into a comma delimited string.
For example, -H "foo:bar" -H "foo:baz" becomes {"foo":"bar,baz"} in the headersIn object.
In this case, a request satisfies the header match {"foo":"bar"} if one of the values specified
in the request header "foo" is "bar".
pleshakov
reviewed
Jun 23, 2022
pleshakov
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
If an
HTTPHeaderMatchcontains entries with equivalent header names, we will only configure the first entry. We will ignore all other entries with that name. Header names are case-insensitive, so "Foo" is equivalent to "foo".If an HTTP request has repeated headers, nginx will merge the values into a comma-delimited string.
For example,
-H "foo:bar" -H "foo:baz"becomes{"foo":"bar,baz"}in the headersIn object. In this case, a request satisfies the header match{"foo":"bar"}if one of the values specified in the request header "foo" is "bar".Checklist
Before creating a PR, run through this checklist and mark each as complete.