Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nginx-docs to CODEOWNERS #1340

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Dec 5, 2023

Proposed changes

Problem: The docs team is not getting PR review requests automatically.

Solution: Add the nginx-docs team as CODEOWNER for the 'site' directory, this way every time a PR is opened with a change in 'site' the team will be notified.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@lucacome lucacome requested a review from a team as a code owner December 5, 2023 21:54
Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for nginx-gateway-fabric canceled.

Name Link
🔨 Latest commit 5beb945
🔍 Latest deploy log https://app.netlify.com/sites/nginx-gateway-fabric/deploys/6570d748c881260008bcec9b

@github-actions github-actions bot added the chore Pull requests for routine tasks label Dec 5, 2023
@sjberman
Copy link
Contributor

sjberman commented Dec 5, 2023

Should also probably do the docs directory.

Problem: The docs team is not getting PR review requests automatically.

Solution: Add the nginx-docs team as CODEOWNER for the 'site' directory, this
way every time a PR is opened with a change in 'site' the team will be
notified.
@lucacome lucacome enabled auto-merge (squash) December 6, 2023 20:19
@lucacome lucacome merged commit 44f0fae into nginxinc:main Dec 6, 2023
27 checks passed
@lucacome lucacome deleted the chore/add-docs-owner branch December 6, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants