Add results of graceful recovery test #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nginx-gateway-fabric canceled.
|
github-actions
bot
added
documentation
kate-osborn
commented
Dec 5, 2023
bjee19
reviewed
Dec 6, 2023
There was a problem hiding this comment.
Would it be beneficial to put a section in the Results that summarizes/highlights any changes/differences from the previous test results - and if there are no differences it can just state that? If one were to look at the results from these tests and wanted to see any changes / keep an eye on errors, it seems a little difficult as is.
pleshakov
approved these changes
Dec 6, 2023
sjberman
approved these changes
Dec 6, 2023
kate-osborn
force-pushed
the
test/graceful-recovery
branch
from
c8bb729
to
ceba7b1
Compare
kate-osborn
force-pushed
the
test/graceful-recovery
branch
from
ab5fea4
to
a183c4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: We need to run the graceful recovery tests for release 1.1.
Solution: Run the graceful recovery tests and record the results.
Closes #1267
Checklist
Before creating a PR, run through this checklist and mark each as complete.