Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump labeler to v5.0.0 and update config #1342

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Bump labeler to v5.0.0 and update config #1342

merged 4 commits into from
Dec 7, 2023

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Dec 6, 2023 •
edited
Loading

Proposed changes

Problem: We started using actions/labeler when it was in alpha and the configuration structure changed in the stable release

Solution: Update actions/labeler to the latest stable version and update the configuration structure accordingly

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@lucacome
Bump labeler to v5.0.0 and update config
4fbea03 
Problem: We started using actions/labeler when it was in alpha and the
configuration structure changed in the stable release

Solution: Update actions/labeler to the latest stable version and update
the configuration structure accordingly
@lucacome lucacome self-assigned this Dec 6, 2023
@lucacome lucacome requested a review from a team as a code owner December 6, 2023 02:21
@netlify Netlify
Copy link

netlify bot commented Dec 6, 2023 •
edited
Loading

✅ Deploy Preview for nginx-gateway-fabric canceled.

Name Link
🔨 Latest commit 7e7b892
🔍 Latest deploy log https://app.netlify.com/sites/nginx-gateway-fabric/deploys/65720f140f5b6000083bca22

@github-actions github-actions bot added the chore Pull requests for routine tasks label Dec 6, 2023
@lucacome lucacome enabled auto-merge (squash) December 7, 2023 18:29
@lucacome lucacome merged commit 03c778b into nginxinc:main Dec 7, 2023
27 checks passed
@lucacome lucacome deleted the chore/update-labeler branch January 16, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjberman sjberman sjberman approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

@kate-osborn kate-osborn kate-osborn approved these changes

@bjee19 bjee19 bjee19 approved these changes

Assignees

@lucacome lucacome

Labels
chore Pull requests for routine tasks
Projects
NGINX Gateway Fabric
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lucacome @sjberman @ciarams87 @kate-osborn @bjee19