Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataplane performance automated test #1356

Merged
merged 11 commits into from
Dec 20, 2023

Conversation

ciarams87
Copy link
Member

@ciarams87 ciarams87 commented Dec 8, 2023

Proposed changes

Problem: Currently, all our NFR tests need to be run manually. This is time consuming every release.

Solution: Use the framework to automate one test to start off.

Testing: Ran the tests against a local kind cluster, locally against a GKE cluster, and on a GCP VM against a GKE cluster

Closes #1286

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Copy link

netlify bot commented Dec 8, 2023

Deploy Preview for nginx-gateway-fabric ready!

Name Link
🔨 Latest commit 797ee693c7a8aba66e6e06bea070283aef7dfc36
🔍 Latest deploy log https://app.netlify.com/sites/nginx-gateway-fabric/deploys/6579ed3005b96b00089d6209
😎 Deploy Preview https://deploy-preview-1356--nginx-gateway-fabric.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation tests Pull requests that update tests labels Dec 8, 2023
tests/framework/script.go Outdated Show resolved Hide resolved
tests/utils/run-tests-gcp-vm.sh Outdated Show resolved Hide resolved
tests/framework/script.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Dec 12, 2023
Copy link
Contributor

@sjberman sjberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to be able to fully remove the dataplane-performance directory. We can migrate the past results into the new results folder.

tests/Makefile Outdated Show resolved Hide resolved
tests/framework/load.go Outdated Show resolved Hide resolved
tests/framework/load.go Outdated Show resolved Hide resolved
tests/framework/request.go Outdated Show resolved Hide resolved
tests/suite/dataplane_perf_test.go Outdated Show resolved Hide resolved
tests/suite/dataplane_perf_test.go Outdated Show resolved Hide resolved
tests/utils/run-tests-gcp-vm.sh Outdated Show resolved Hide resolved
tests/README.md Show resolved Hide resolved
@ciarams87
Copy link
Member Author

@sjberman

I'd like to be able to fully remove the dataplane-performance directory. We can migrate the past results into the new results folder.

I removed it in the first commit, I think you can possibly just see the files being renamed?

Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran it on GCP. worked as expected

tests/README.md Show resolved Hide resolved
tests/utils/run-tests-gcp-vm.sh Outdated Show resolved Hide resolved
tests/suite/dataplane_perf_test.go Outdated Show resolved Hide resolved
@ciarams87 ciarams87 force-pushed the tests/automate-dp-perf branch 4 times, most recently from fff33ff to dbb92be Compare December 13, 2023 16:33
@ciarams87 ciarams87 changed the title DRAFT: Add dataplane performance automated test Add dataplane performance automated test Dec 13, 2023
@ciarams87 ciarams87 marked this pull request as ready for review December 13, 2023 17:05
@ciarams87 ciarams87 requested a review from a team as a code owner December 13, 2023 17:05
tests/README.md Outdated Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
tests/README.md Show resolved Hide resolved
tests/framework/resourcemanager.go Show resolved Hide resolved
tests/framework/resourcemanager.go Outdated Show resolved Hide resolved
tests/framework/resourcemanager.go Outdated Show resolved Hide resolved
tests/framework/resourcemanager.go Show resolved Hide resolved
tests/scripts/vars.env Outdated Show resolved Hide resolved
tests/suite/dataplane_perf_test.go Outdated Show resolved Hide resolved
tests/scripts/vars.env-example Show resolved Hide resolved
tests/suite/dataplane_perf_test.go Outdated Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
tests/scripts/create-and-setup-gcp-vm.sh Outdated Show resolved Hide resolved
tests/scripts/vars.env-example Outdated Show resolved Hide resolved
tests/scripts/vars.env-example Show resolved Hide resolved
tests/Makefile Show resolved Hide resolved
tests/framework/ngf.go Show resolved Hide resolved
Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

I tested this on GCP and it worked like a charm!

@ciarams87 ciarams87 enabled auto-merge (squash) December 20, 2023 22:32
@ciarams87 ciarams87 merged commit 5e0d723 into nginxinc:main Dec 20, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation tests Pull requests that update tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Automate Data Plane Performance Test
5 participants