Support for URL Rewrite filter #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
|
@ADubhlaoich Docs additions can be viewed in the second commit. |
sjberman
force-pushed
the
enh/url-rewrite
branch
2 times, most recently
from
a9c5be5
to
23f7b2e
Compare
bjee19
requested changes
Dec 18, 2023
pleshakov
suggested changes
Dec 18, 2023
site/content/how-to/traffic-management/redirects-and-rewrites.md
Outdated
Show resolved
Hide resolved
kate-osborn
requested changes
Dec 19, 2023
site/content/how-to/traffic-management/redirects-and-rewrites.md
Outdated
Show resolved
Hide resolved
site/content/how-to/traffic-management/redirects-and-rewrites.md
Outdated
Show resolved
Hide resolved
site/content/how-to/traffic-management/redirects-and-rewrites.md
Outdated
Show resolved
Hide resolved
site/content/how-to/traffic-management/redirects-and-rewrites.md
Outdated
Show resolved
Hide resolved
sjberman
force-pushed
the
enh/url-rewrite
branch
from
fc8655d
to
cf6f1bd
Compare
kate-osborn
approved these changes
Dec 19, 2023
pleshakov
approved these changes
Dec 19, 2023
bjee19
approved these changes
Dec 19, 2023
Problem: As a user, I want to be able to configure URL rewrites for hostname and/or path rewrites on the server side. Solution: Using the HTTPRoute filter API, a user can now configure a hostname and/or path-based rewrite. Hostname rewrite will update the Host header, while a path rewrite utilizes nginx's `rewrite` directive. Enabled conformance tests for these features and added how-to guides.
sjberman
force-pushed
the
enh/url-rewrite
branch
from
0b0c455
to
2bb1509
Compare
ADubhlaoich
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: As a user, I want to be able to configure URL rewrites for hostname and/or path rewrites on the server side.
Solution: Using the HTTPRoute filter API, a user can now configure a hostname and/or path-based rewrite. Hostname rewrite will update the Host header, while a path rewrite utilizes nginx's
rewritedirective.Enabled conformance tests for these features and added how-to guides. Due to the commonalities between redirects/rewrites, decided to just convert our HTTPS termination example into a user guide to cover our current redirect support.
Testing: Verified various combinations of rewrites using query params, headers, etc.
Closes #534