-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTPS Termination #140
HTTPS Termination #140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kate-osborn Please see my review
This commit adds support for HTTPS listeners with a TLS mode of Terminate. Multiple HTTPS listeners are supported provided their hostnames do not conflict. Additionally, a gateway can have an HTTP and HTTPS listener with the same hostname. Limitations: - HTTPS listeners must listen on port 443 - Supports a single reference to a Kubernetes Secret of type kubernetes.io/tls - Secret must be in the same namespace as the Gateway - Secret must be created before the HTTPRoutes are created - Secret rotation is not supported
10a9e0e
to
f2b6cbe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @kate-osborn
a few more suggestions and questions based on the new code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few more comments/suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This commit adds support for HTTPS listeners with a TLS mode of Terminate.
Multiple HTTPS listeners are supported provided their hostnames do not conflict.
Additionally, a gateway can have an HTTP and HTTPS listener with the same
hostname.
Limitations:
Checklist