Prevent paths in HTTPRoute matches from conflicting with internal locations in NGINX

[salonichf5]

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: To simplify routing, generated locations should be different from defined http route locations.

Solution:

1. Updated internal location block prefix to be named to `rule%d-route%d
2. Removed internal directive from server block
3. Simplified Rewrite & Redirect for url

Testing:

1. Updated unit tests
2. Did manual testing

curl request with version 2 header returns response from coffee-2

sa.choudhary@JX46X2W221 cafe % curl --resolve cafe.example.com:$GW_PORT:$GW_IP http://cafe.example.com:$GW_PORT/coffee -H "version:v2"
Handling connection for 8080
Server address: 10.244.0.25:8080
Server name: coffee-v2-7d47fc86cb-4mkkf
Date: 04/Jan/2024:23:46:55 +0000
URI: /coffee
Request ID: c71364174305814d8385e33a05575aa9

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #428

Checklist

Before creating a PR, run through this checklist and mark each as complete.

• I have read the CONTRIBUTING doc
• I have added tests that prove my fix is effective or that my feature works
• I have checked that all unit tests pass after adding my changes
• I have updated necessary documentation
• I have rebased my branch onto main
• I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

[ADubhlaoich]

LGTM on the docs side - since the changes in the PR are primarily code-based I will not make an approval.

[pleshakov]

thanks @salonichf5

this looks good. per review comment, let's update the prefix so that we don't need any restrictions on paths in HTTPRoute routing rules

[kate-osborn]

@salonichf5 can you update the PR description to reflect the new approach?

[sjberman]

@pleshakov Do you think with this change we still need the internal; directive? Is it redundant, or does it still add value?

[pleshakov]

@sjberman
Is it redundant

[kate-osborn]

🚀