Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build NGINX Plus images #1477

Merged
merged 5 commits into from
Jan 31, 2024
Merged

Build NGINX Plus images #1477

merged 5 commits into from
Jan 31, 2024

Conversation

lucacome
Copy link
Member

Proposed changes

Problem: Building the NGINX Plus image is a manual step

Solution: Add automated build in the pipeline

Closes #1361

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the chore Pull requests for routine tasks label Jan 18, 2024
@lucacome lucacome marked this pull request as ready for review January 18, 2024 03:29
@lucacome lucacome requested a review from a team as a code owner January 18, 2024 03:29
@lucacome lucacome requested a review from a team as a code owner January 19, 2024 04:07
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 19, 2024
sjberman
sjberman reviewed Jan 19, 2024
View reviewed changes
build/Dockerfile.nginx Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
kate-osborn
kate-osborn approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucacome lucacome force-pushed the chore/nginx-plus-ci branch 4 times, most recently from 2a4461d to 8379412 Compare January 25, 2024 05:50
@sjberman
Copy link
Contributor

There are a few references to nginxplus name in the docs. May just want to grep for those.

ADubhlaoich
ADubhlaoich reviewed Jan 29, 2024
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on docs side, not approving since the PR content is not docs-focused.

@lucacome
Build NGINX Plus images
8d7f242 
Problem: Building the NGINX Plus image is a manual step

Solution: Add automated build in the pipeline
kate-osborn
kate-osborn reviewed Jan 31, 2024
View reviewed changes
Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc changes LGTM

docs/developer/branching-and-workflow.md Outdated Show resolved Hide resolved
@lucacome @kate-osborn
Update docs/developer/branching-and-workflow.md
3b87981 
Co-authored-by: Kate Osborn <50597707+kate-osborn@users.noreply.github.com>
@lucacome lucacome merged commit ca0ce36 into main Jan 31, 2024
28 checks passed
@lucacome lucacome deleted the chore/nginx-plus-ci branch January 31, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov left review comments

@ADubhlaoich ADubhlaoich ADubhlaoich left review comments

@kate-osborn kate-osborn kate-osborn approved these changes

@sjberman sjberman sjberman approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automated Building and Pushing of NGINX+ NGF Images
5 participants
@lucacome @sjberman @pleshakov @ADubhlaoich @kate-osborn