Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release-note section in PR template #1574

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Feb 14, 2024

Proposed changes

Problem: Writing release notes at release time takes a long time and it's not easy to do if you don't have as much context as the submitter or simply too much time has passed.

Solution: Add a release notes section to be filled out when opening a PR. This way at release time we can just grab all the descriptions and speed up the process.

Closes #1034

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Problem: Writing release notes at release time takes a long time and
it's not easy to do if you don't have as much context as the submitter
or simply too much time has passed.

Solution: Add a release notes section to be filled out when opening a
PR. This way at release time we can just grab all the descriptions and
speed up the process.
@lucacome lucacome self-assigned this Feb 14, 2024
@lucacome lucacome requested review from a team as code owners February 14, 2024 06:19
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 14, 2024
@sjberman
Copy link
Contributor

Just so I understand, there's no automatic process as of right now that uses the new note in the generated release notes, right? When writing our curated notes, it's still manual, but this just gives us a note to reference?

@lucacome
Copy link
Member Author

yep the generated notes are still the same (and we should probably still keep them the same?), this would be for the curated notes that is still a manual process (for now)

Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lucacome lucacome enabled auto-merge (squash) February 15, 2024 00:58
@lucacome lucacome merged commit f8601db into nginxinc:main Feb 15, 2024
30 checks passed
@lucacome lucacome deleted the docs/add-release-notes branch April 1, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Note to include PR in changelog
4 participants