Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "build images" link from README #1575

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

sjberman
Copy link
Contributor

The Getting Started guide refers to deploying and installing NGF, which doesn't require building an image. This link doesn't make sense to have after these steps, and that guide is mainly written as an alternate option for devs. In the context of Getting Started, it feels unnecessary, and can be found through the docs naturally if needed.

The Getting Started guide refers to deploying and installing NGF, which doesn't require building an image. This link doesn't make sense to have after these steps, and that guide is mainly written  as an alternate option for devs. In the context of Getting Started, it feels unnecessary, and can be found through the docs naturally if needed.
@sjberman sjberman requested a review from a team as a code owner February 14, 2024 15:05
@github-actions github-actions bot added documentation Improvements or additions to documentation chore Pull requests for routine tasks labels Feb 14, 2024
Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjberman sjberman enabled auto-merge (squash) February 15, 2024 15:28
@sjberman sjberman merged commit 8c79fab into nginxinc:main Feb 15, 2024
34 checks passed
@sjberman sjberman deleted the chore/remove-readme-link branch February 15, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants