Collect Deployment Flag Options

[bjee19]

Problem: We want to collect deployment flag options so we can understand what a typical installation is using.

Solution: Collect the deployment flag options.

Testing: Unit tests and E2E testing.

With the deployment flag keys and values paired, this is what we get printed in the logs with a default installation.

config: user-defined

gateway: default

gateway-ctlr-name: user-defined

gatewayclass: user-defined

health-disable: false

health-port: default

help: false

leader-election-disable: false

leader-election-lock-name: user-defined

metrics-disable: false

metrics-port: default

metrics-secure-serving: false

nginx-plus: false

service: “user-defined”

update-gatewayclass-status: “true”

Closes #1315

Checklist

Before creating a PR, run through this checklist and mark each as complete.

• I have read the CONTRIBUTING doc
• I have added tests that prove my fix is effective or that my feature works
• I have checked that all unit tests pass after adding my changes
• I have updated necessary documentation
• I have rebased my branch onto main
• I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

[bjee19]

E2E test results:

With Option 3 of DeploymentFlagOptions where there is one slice for all the flag keys and one slice for all the flag values, this is what is printed for the default installation through helm.

"DeploymentFlagOptions":{"FlagKeys":["config","gateway","gateway-ctlr-name","gatewayclass","health-disable","health-port","help","leader-election-disable","leader-election-lock-name","metrics-disable","metrics-port","metrics-secure-serving","nginx-plus","service","update-gatewayclass-status"],"FlagValues":["user-defined","default","user-defined","user-defined","false","default","false","false","user-defined","false","default","false","false","user-defined","true"]}

Parsed out into matching keys and values this is the output:

config: user-defined

gateway: default

gateway-ctlr-name: user-defined

gatewayclass: user-defined

health-disable: false

health-port: default

help: false

leader-election-disable: false

leader-election-lock-name: user-defined

metrics-disable: false

metrics-port: default

metrics-secure-serving: false

nginx-plus: false

service: user-defined

update-gatewayclass-status: true

This seems correct to me with our current definition of "user-defined" and "default" values. In the installation I changed the health port and it did correctly change from default -> user-defined.

[bjee19]

Are we satisfied with these results / do we get much out of this data? Currently there are no "default" values for basically all of the string flags so they will always be "user-defined" if they are set at all (which leads into this next point). Also, if a user does the regular quick start deployment, the values in the helm template are set and will be recorded as "user-defined" even if they are the "default" values for a default deployment.

@mpstefan Do you have any questions for this data?

[ciarams87]

🚀

[bjee19]

E2E log output:

config: user-defined

gateway: default

gateway-api-experimental-features: false

gateway-ctlr-name: user-defined

gatewayclass: user-defined

health-disable: false

health-port: default

help: false

leader-election-disable: false

leader-election-lock-name: user-defined

metrics-disable: false

metrics-port: default 

metrics-secure-serving: false

nginx-plus: false

product-telemetry-disable: false

service: user-defined

update-gatewayclass-status: true

usage-report-cluster-name: default

usage-report-secret: default

usage-report-server-url: default

usage-report-skip-verify: false