Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove webhook validation code #1590

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Conversation

ciarams87
Copy link
Member

@ciarams87 ciarams87 commented Feb 15, 2024

Proposed changes

Problem: The webhook validation code has been removed from the upstream Gateway API repo, causing import errors when we try and run the conformance tests against the main branch of the Gateway API repo.

Solution: Remove the web hook validation code from our repo, and remove the web hook assumption panics. Also add additional validation for case not covered by CEL validation (see kubernetes-sigs/gateway-api#2277)

Testing: Added additional unit tests where appropriate, ran the conformance test suite against the GW API main branch

Closes #1512

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@ciarams87 ciarams87 requested a review from a team as a code owner February 15, 2024 18:28
@github-actions github-actions bot added bug Something isn't working documentation Improvements or additions to documentation labels Feb 15, 2024
@sjberman
Copy link
Contributor

One validation is not supported by CEL and needs to be implemented manually: kubernetes-sigs/gateway-api#2277

design/resource-validation.md Show resolved Hide resolved
internal/mode/static/state/graph/httproute.go Outdated Show resolved Hide resolved
internal/mode/static/state/graph/httproute_test.go Outdated Show resolved Hide resolved
@ciarams87 ciarams87 requested a review from a team as a code owner February 19, 2024 11:49
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the docs side of things.

Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ciarams87 ciarams87 merged commit 8d5f023 into nginxinc:main Feb 20, 2024
34 checks passed
@ciarams87 ciarams87 deleted the fix/remove-webhook branch February 20, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Nightly Conformance Tests Fail
5 participants