Add flag to opt out of product telemetry #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
sjberman
force-pushed
the
chore/telemetry-opt-out
branch
from
5f75a28
to
3ed2ffd
Compare
|
FYI - license telemetry cannot be opted out of when N+, that is not an option. |
|
@brianehlert Yes, this is just for XCDF. |
salonichf5
reviewed
Feb 21, 2024
pleshakov
reviewed
Feb 21, 2024
Problem: As a user of NGF I want an easy option to opt out of recording and sending of all telemetry data So that if I am not comfortable sending that information, I can still continue to use NGF Solution: Added a new configurable flag that can disable telemetry. On by default. Also turns off any RBAC if not needed (for N+ usage or telemetry)
sjberman
force-pushed
the
chore/telemetry-opt-out
branch
from
3ed2ffd
to
d04d2c0
Compare
pleshakov
approved these changes
Feb 21, 2024
kate-osborn
requested changes
Feb 21, 2024
salonichf5
approved these changes
Feb 22, 2024
ciarams87
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: As a user of NGF
I want an easy option to opt out of recording and sending of all telemetry data So that if I am not comfortable sending that information, I can still continue to use NGF
Solution: Added a new configurable flag that can disable telemetry. On by default. Also turns off any RBAC if not needed (for N+ usage or telemetry)
Testing: Verified RBAC permissions are set properly when telemetry is on/off or nginx plus is on/off.
Closes #1317
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.