Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Gateway API compatibility doc #1606

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

kate-osborn
Copy link
Contributor

Proposed changes

Problem: The compatibility doc states that URLRewrite and RequestHeaderModifier filters are incompatible but should be URLRewrite and RequestRedirect.

Solution: Update the doc so it states that URLRewrite and RequestRedirect filters are incompatible.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@kate-osborn kate-osborn requested review from a team as code owners February 22, 2024 01:40
@github-actions github-actions bot added documentation Improvements or additions to documentation chore Pull requests for routine tasks labels Feb 22, 2024
@kate-osborn kate-osborn merged commit f13b99f into nginxinc:main Feb 22, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants