Product Telemetry collection document #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
ADubhlaoich
approved these changes
Feb 26, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
pleshakov
reviewed
Feb 26, 2024
bjee19
reviewed
Feb 26, 2024
bjee19
reviewed
Feb 26, 2024
bjee19
approved these changes
Feb 28, 2024
salonichf5
reviewed
Mar 8, 2024
salonichf5
approved these changes
Mar 8, 2024
|
@sjberman would it make sense to add a connection to Telemetry service here https://github.com/nginxinc/nginx-gateway-fabric/blob/main/site/content/overview/gateway-architecture.md#the-nginx-gateway-fabric-pod ? I think we can just add it to a list so that we don't clutter the diagram. For example:
Below are additional connections not depicted on the diagram:
|
Problem: Users will want to understand how and why we collect product telemetry, as well as how to opt-out if desired. Solution: Add a document explaining these things.
Co-authored-by: Alan Dooley <github@adubhlaoi.ch>
sjberman
force-pushed
the
docs/product-telemetry
branch
from
c9fe755
to
2b3de20
Compare
pleshakov
approved these changes
Mar 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1614 +/- ##
============================================
- Coverage 100.00% 85.93% -14.07%
============================================
Files 1 87 +86
Lines 209 5511 +5302
Branches 52 52
============================================
+ Hits 209 4736 +4527
- Misses 0 723 +723
- Partials 0 52 +52 ☔ View full report in Codecov by Sentry. |
amimimor
pushed a commit
to amimimor/nginx-gateway-fabric
that referenced
this pull request
Apr 3, 2024
Problem: Users will want to understand how and why we collect product telemetry, as well as how to opt-out if desired. Solution: Add a document explaining these things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Users will want to understand how and why we collect product telemetry, as well as how to opt-out if desired.
Solution: Add a document explaining these things.
Closes #1319
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.