Add NFR workflow #1621
Merged
Add NFR workflow #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
ciarams87
force-pushed
the
chore/nfr-workflow
branch
2 times, most recently
from
0ccb8aa
to
9c8da9d
Compare
sjberman
reviewed
Feb 28, 2024
ciarams87
force-pushed
the
chore/nfr-workflow
branch
from
9c8da9d
to
2e72e6c
Compare
kate-osborn
reviewed
Feb 28, 2024
|
@ciarams87 looks good! I wonder if we should document this workflow anywhere...Would it make sense in the release process doc? |
bjee19
reviewed
Feb 28, 2024
ciarams87
force-pushed
the
chore/nfr-workflow
branch
from
9f0e621
to
b17953c
Compare
|
Scale tests are gonna require a much bigger cluster. I wonder if we just create a big cluster to begin with and all tests run on that. |
bjee19
approved these changes
Feb 29, 2024
ciarams87
force-pushed
the
chore/nfr-workflow
branch
from
b17953c
to
37c7ea4
Compare
@sjberman Maybe, but should we leave that for the scale test automation story? Some of these tests may need to be ran alone (like longevity), I'm not sure if scale test will fall into that bracket, but until the scale test story is automated we won't know for sure. Bigger clusters = $$$ so until we're sure we need them, I'd rather wait. |
sjberman
approved these changes
Mar 5, 2024
amimimor
pushed a commit
to amimimor/nginx-gateway-fabric
that referenced
this pull request
Apr 3, 2024
* Add NFR workflow * Initial review feedback * Fix typos, update docs, and remove image builds unless plus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: As a maintainer of the NGF project
I want the ability to kick off all non-functional tests on demand
So that when I am making a release, I do not need to manage running all the tests myself.
Solution: Create a workflow that's runs on
workflow_dispatchthat can be ran by someone with write access only to the repo (i.e. the maintainers). There are optional inputs fortest_label, whether nginx plus is to be used, and what version of NGF we are testing (this should be the next release version when running release testing).Also added bash scripts for creating and tearing down GKE clusters.
Testing: Tested as much as possible locally using act, but the identity federation auth mechanism and the PR opening step cannot be tested fully locally. This cannot be fully tested until the workflow is merged into main (as 1. the workflow needs to be in main for the
workflow_dispatchmechanism to work, and 2. we need access to secrets which are not possible from a fork).Closes #1506
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.