Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Node to v20 and add .nvmrc #1627

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Feb 29, 2024

Proposed changes

Problem: We don't have a way to keep track of Node version and we're not using the latest LTS

Solution: Add .nvmrc, set it to v20 and use it in the Workflows and Makefile.
Also uploads code coverage for the modules.

Note: Switched to vitest because c8 was generating invalid coverage report, and didn't seem to read any configuration files.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner February 29, 2024 02:46
@github-actions github-actions bot added documentation Improvements or additions to documentation chore Pull requests for routine tasks labels Feb 29, 2024
@lucacome lucacome force-pushed the chore/update-node branch 2 times, most recently from dc748a2 to b77011d Compare February 29, 2024 03:22
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.27%. Comparing base (2b0a255) to head (ea7752b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1627      +/-   ##
==========================================
+ Coverage   85.71%   86.27%   +0.55%     
==========================================
  Files          83       84       +1     
  Lines        5181     5390     +209     
  Branches        0       52      +52     
==========================================
+ Hits         4441     4650     +209     
  Misses        689      689              
  Partials       51       51              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacome lucacome force-pushed the chore/update-node branch 2 times, most recently from 5d9f7a1 to 935812d Compare February 29, 2024 03:32
Problem: We don't have a way to keep track of Node version and we're not
using the latest LTS

Solution: Add .nvmrc, set it to v20 and use it in the Workflows and
Makefile.
Also uploads code coverage for the modules.
@lucacome lucacome enabled auto-merge (squash) February 29, 2024 17:51
@lucacome lucacome merged commit 45940f9 into nginxinc:main Feb 29, 2024
34 checks passed
@lucacome lucacome deleted the chore/update-node branch April 1, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants