-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate telemetry exporter #1656
Conversation
Problem: Integrate the exporter library https://github.com/nginxinc/telemetry-exporter so that it is possible to send product telemetry data to an endpoint. Solution: - Integrate the exporter library. - Update existing telemetry data struct to use the common data struct defined in the exporter library. - Refactor existing telemetry data structs to adhere to the exporter library requirements. - Generate scheme and Attributes for data structs. - Allow configuring telemetry endpoint params via build flags. If the telemetry endpoint is not specified, NGF will log data points to the debug log (existing behavior). - Add root CA certs to NGF image so that NGF can verify the cert of the telemetry service. Testing: - Unit tests - Manual testing of build flags validation. - Manual testing that NGF sends data to an OTel collector. - Manual testing that NGF sends data to a dev F5 telemetry service. CLOSES -- #1377
I realized I'm using the branch instead of a fork. This is by mistake. However, I'd keep this PR, so no more PRs created. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1656 +/- ##
==========================================
- Coverage 86.27% 85.83% -0.44%
==========================================
Files 84 86 +2
Lines 5390 5459 +69
Branches 52 52
==========================================
+ Hits 4650 4686 +36
- Misses 689 722 +33
Partials 51 51 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀
Problem: Integrate the exporter library https://github.com/nginxinc/telemetry-exporter so that it is possible to send product telemetry data to an endpoint. Solution: - Integrate the exporter library. - Update existing telemetry data struct to use the common data struct defined in the exporter library. - Refactor existing telemetry data structs to adhere to the exporter library requirements. - Generate scheme and Attributes for data structs. - Allow configuring telemetry endpoint params via build flags. If the telemetry endpoint is not specified, NGF will log data points to the debug log (existing behavior). - Add root CA certs to NGF image so that NGF can verify the cert of the telemetry service. Testing: - Unit tests - Manual testing of build flags validation. - Manual testing that NGF sends data to an OTel collector. - Manual testing that NGF sends data to a dev F5 telemetry service. CLOSES -- nginxinc#1377
Proposed changes
Problem:
Integrate the exporter library
https://github.com/nginxinc/telemetry-exporter so that it is possible to send product telemetry data to an endpoint.
Solution:
Testing:
CLOSES -- #1377
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.