Integrate telemetry exporter #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Integrate the exporter library https://github.com/nginxinc/telemetry-exporter so that it is possible to send product telemetry data to an endpoint. Solution: - Integrate the exporter library. - Update existing telemetry data struct to use the common data struct defined in the exporter library. - Refactor existing telemetry data structs to adhere to the exporter library requirements. - Generate scheme and Attributes for data structs. - Allow configuring telemetry endpoint params via build flags. If the telemetry endpoint is not specified, NGF will log data points to the debug log (existing behavior). - Add root CA certs to NGF image so that NGF can verify the cert of the telemetry service. Testing: - Unit tests - Manual testing of build flags validation. - Manual testing that NGF sends data to an OTel collector. - Manual testing that NGF sends data to a dev F5 telemetry service. CLOSES -- #1377
github-actions
bot
added
documentation
|
I realized I'm using the branch instead of a fork. This is by mistake. However, I'd keep this PR, so no more PRs created. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1656 +/- ##
==========================================
- Coverage 86.27% 85.83% -0.44%
==========================================
Files 84 86 +2
Lines 5390 5459 +69
Branches 52 52
==========================================
+ Hits 4650 4686 +36
- Misses 689 722 +33
Partials 51 51 ☔ View full report in Codecov by Sentry. |
kate-osborn
reviewed
Mar 7, 2024
sjberman
approved these changes
Mar 7, 2024
amimimor
pushed a commit
to amimimor/nginx-gateway-fabric
that referenced
this pull request
Apr 3, 2024
Problem: Integrate the exporter library https://github.com/nginxinc/telemetry-exporter so that it is possible to send product telemetry data to an endpoint. Solution: - Integrate the exporter library. - Update existing telemetry data struct to use the common data struct defined in the exporter library. - Refactor existing telemetry data structs to adhere to the exporter library requirements. - Generate scheme and Attributes for data structs. - Allow configuring telemetry endpoint params via build flags. If the telemetry endpoint is not specified, NGF will log data points to the debug log (existing behavior). - Add root CA certs to NGF image so that NGF can verify the cert of the telemetry service. Testing: - Unit tests - Manual testing of build flags validation. - Manual testing that NGF sends data to an OTel collector. - Manual testing that NGF sends data to a dev F5 telemetry service. CLOSES -- nginxinc#1377
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem:
Integrate the exporter library
https://github.com/nginxinc/telemetry-exporter so that it is possible to send product telemetry data to an endpoint.
Solution:
Testing:
CLOSES -- #1377
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.