Avoid unnecessary build of NGF #1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When building an NGF image, building NGF binary will always happen, even if it's not needed (Docker build target is not local) Solution: Fix it by adding a stage for a container that holds CA certs. Introduced in 799ea76 Closes nginxinc#1680
kate-osborn
approved these changes
Mar 13, 2024
lucacome
approved these changes
Mar 13, 2024
amimimor
pushed a commit
to amimimor/nginx-gateway-fabric
that referenced
this pull request
Apr 3, 2024
Problem: When building an NGF image, building NGF binary will always happen, even if it's not needed (Docker build target is not local) Solution: Fix it by adding a stage for a container that holds CA certs. Introduced in 799ea76 Closes nginxinc#1680
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem:
When building an NGF image, building NGF binary will always happen, even if it's not needed (Docker build target is not local)
Solution:
Fix it by adding a stage for a container that holds CA certs.
Introduced in 799ea76
Closes #1680
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.